Remove some useless if statements

diff --git a/src/ChangeLog b/src/ChangeLog
index b3766ced84e0b9d8fbec1ebb3b9458a1ee87bcc8..3d6699cb1c1c8ff9918fd32184692700aa499f0d 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2013-12-29  Giuseppe Scrivano  <gscrivan@redhat.com>
+
+       * init.c (home_dir): Remove useless 'if'.
+       * warc.c (warc_start_new_file): Likewise.
+       (warc_process_cdx_line): Likewise.
+       (warc_write_response_record): Likewise.
+
 2013-12-26  Tim Ruehsen  <tim.ruehsen@gmx.de>
 
        * gnutls.c (ssl_connect_wget): Fix connect timeout failure

diff --git a/src/init.c b/src/init.c
index 84ae654cfc8e75b062548e157862f04eacaecf74..a64dabe6ad9f453cdc13282a2665771b2dee9763 100644 (file)
--- a/src/init.c
+++ b/src/init.c
@@ -462,8 +462,7 @@ home_dir (void)
     }
 
   ret = home ? xstrdup (home) : NULL;
-  if (buf)
-    free (buf);
+  free (buf);
 
   return ret;
 }

diff --git a/src/warc.c b/src/warc.c
index 41f522af5ecd880b816267f5531f73f3c028f055..c3a5857203ab490b28b22ec8edffad4293f2f9ce 100644 (file)
--- a/src/warc.c
+++ b/src/warc.c
@@ -726,10 +726,9 @@ warc_start_new_file (bool meta)
 
   if (warc_current_file != NULL)
     fclose (warc_current_file);
-  if (warc_current_warcinfo_uuid_str)
-    free (warc_current_warcinfo_uuid_str);
-  if (warc_current_filename)
-    free (warc_current_filename);
+  
+  free (warc_current_warcinfo_uuid_str);
+  free (warc_current_filename);
 
   warc_current_file_number++;
 
@@ -918,8 +917,7 @@ warc_process_cdx_line (char *lineptr, int field_num_original_url,
       else
         {
           free (original_url);
-          if (checksum_v != NULL)
-            free (checksum_v);
+          free (checksum_v);
           free (record_id);
         }
     }
@@ -1417,10 +1415,8 @@ warc_write_response_record (char *url, char *timestamp_str,
       response_uuid);
     }
 
-  if (block_digest)
-    free (block_digest);
-  if (payload_digest)
-    free (payload_digest);
+  free (block_digest);
+  free (payload_digest);
 
   return warc_write_ok;
 }