[svn] Dan Berger responded to my email. Added his explanation of what his patch was

coded for (downloading StarOffice from Sun's website).  He says he doesn't use
wget any more, so he won't be writing a patch that allows downloading that
without breaking anything (such a patch would apparently involve stopping
certain characters in the URL from being escaped).

diff --git a/src/ChangeLog b/src/ChangeLog
index bdc94cde7d59efda9bc9a3c08a7333aa9f02c27f..deda3ca3a669c53c9baec76ac10df53cdb16b8bf 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -4,16 +4,17 @@
        braces to avoid ambiguous `else'" warnings.  Eliminated them.
        
        * http.c (gethttp): Dan Berger's query string patch is totally
-       bogus.  If you have two different URLs, gen_page.cgi?page1 and
-       get_page.cgi?page2, they'll both be saved as get_page.cgi and the
-       second will overwrite the first.  Also, parameters to implicit
-       CGIs, like "http://www.host.com/db/?2000-03-02" cause the URLs to
-       be printed with trailing garbage characters, and could seg fault.
-       I'm not sure what Dan had in mind with this patch (no explanatory
-       comments), but I'm removing it for now.  If he can rewrite it so
-       it doesn't break stuff, okay.
-       (http_loop): Heiko introduced "suggest explicit
-       braces to avoid ambiguous `else'" warnings.  Eliminated them.
+       bogus.  If you have two different URLs, gen_page.cgi?page1 and
+       get_page.cgi?page2, they'll both be saved as get_page.cgi and the
+       second will overwrite the first.  Also, parameters to implicit
+       CGIs, like "http://www.host.com/db/?2000-03-02" cause the URLs to
+       be printed with trailing garbage characters, and could seg fault.
+       Backing out the patch, which Dan B. informed me by email was just
+       a kludge to download StarOffice from Sun made necessary due to
+       wget's unconditional escaping of certain characters (room for an
+       option there?).
+       (http_loop): Heiko introduced "suggest explicit braces to avoid
+       ambiguous `else'" warnings.  Eliminated them.
        
        * main.c: Heiko's --wait / --waitretry backwards compatibility
        code looks to have been totally untested -- automatic variable