Silent compiler warning.

diff --git a/src/ChangeLog b/src/ChangeLog
index f12875e1b1b155a703b7892377733fe1559c7c0f..08266a73a4b889287a4530328b0e97dd8d447893 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -4,6 +4,8 @@
 
        * http.c (gethttp): Fix memory leak.
 
 
        * http.c (gethttp): Fix memory leak.
 

+       * ftp.c (getftp): Silent compiler warning.
+

 2009-06-14  Phil Pennock  <mutt-dev@spodhuis.org> (tiny change)
        * host.h: Declare `is_valid_ip_address'.
        * host.c (is_valid_ip_address): New function.
 2009-06-14  Phil Pennock  <mutt-dev@spodhuis.org> (tiny change)
        * host.h: Declare `is_valid_ip_address'.
        * host.c (is_valid_ip_address): New function.

diff --git a/src/ftp.c b/src/ftp.c
index 989a1ddab4d934f7e8c151fe99b527aedfcdaac9..669e66373e1f384f5bb5c6d535c43c1a1c86b4d7 100644 (file)
--- a/src/ftp.c
+++ b/src/ftp.c
@@ -247,9 +247,8 @@ getftp (struct url *u, wgint passed_expected_bytes, wgint *qtyread,
   int csock, dtsock, local_sock, res;
   uerr_t err = RETROK;          /* appease the compiler */
   FILE *fp;
   int csock, dtsock, local_sock, res;
   uerr_t err = RETROK;          /* appease the compiler */
   FILE *fp;

-  char *user, *passwd, *respline;
-  char *tms;
-  const char *tmrate;
+  char *respline, *tms;
+  const char *user, *passwd, *tmrate;

   int cmd = con->cmd;
   bool pasv_mode_open = false;
   wgint expected_bytes = 0;
   int cmd = con->cmd;
   bool pasv_mode_open = false;
   wgint expected_bytes = 0;


@@ -289,13 +288,6 @@ getftp (struct url *u, wgint passed_expected_bytes, wgint *qtyread,
     {
       char    *host = con->proxy ? con->proxy->host : u->host;
       int      port = con->proxy ? con->proxy->port : u->port;
     {
       char    *host = con->proxy ? con->proxy->host : u->host;
       int      port = con->proxy ? con->proxy->port : u->port;

-      char *logname = user;
-
-      if (con->proxy)
-        {
-          /* If proxy is in use, log in as username@target-site. */
-          logname = concat_strings (user, "@", u->host, (char *) 0);
-        }

 
       /* Login to the server: */
 
 
       /* Login to the server: */
 


@@ -303,20 +295,10 @@ getftp (struct url *u, wgint passed_expected_bytes, wgint *qtyread,
 
       csock = connect_to_host (host, port);
       if (csock == E_HOST)
 
       csock = connect_to_host (host, port);
       if (csock == E_HOST)

-        {
-          if (con->proxy)
-            xfree (logname);
-

           return HOSTERR;
           return HOSTERR;

-        }

       else if (csock < 0)
       else if (csock < 0)

-        {
-          if (con->proxy)
-            xfree (logname);
-

           return (retryable_socket_connect_error (errno)
                   ? CONERROR : CONIMPOSSIBLE);
           return (retryable_socket_connect_error (errno)
                   ? CONERROR : CONIMPOSSIBLE);

-        }

 
       if (cmd & LEAVE_PENDING)
         con->csock = csock;
 
       if (cmd & LEAVE_PENDING)
         con->csock = csock;


@@ -328,10 +310,15 @@ getftp (struct url *u, wgint passed_expected_bytes, wgint *qtyread,
                  quotearg_style (escape_quoting_style, user));
       if (opt.server_response)
         logputs (LOG_ALWAYS, "\n");
                  quotearg_style (escape_quoting_style, user));
       if (opt.server_response)
         logputs (LOG_ALWAYS, "\n");

-      err = ftp_login (csock, logname, passwd);
-

       if (con->proxy)
       if (con->proxy)

-        xfree (logname);
+        {
+          /* If proxy is in use, log in as username@target-site. */
+          char *logname = concat_strings (user, "@", u->host, (char *) 0);
+          err = ftp_login (csock, logname, passwd);
+          xfree (logname);
+        }
+      else
+        err = ftp_login (csock, user, passwd);

 
       /* FTPRERR, FTPSRVERR, WRITEFAILED, FTPLOGREFUSED, FTPLOGINC */
       switch (err)
 
       /* FTPRERR, FTPSRVERR, WRITEFAILED, FTPLOGREFUSED, FTPLOGINC */
       switch (err)


@@ -514,7 +501,7 @@ Error in server response, closing control connection.\n"));
         logputs (LOG_VERBOSE, _("==> CWD not needed.\n"));
       else
         {
         logputs (LOG_VERBOSE, _("==> CWD not needed.\n"));
       else
         {

-          char *targ = NULL;
+          const char *targ = NULL;

           int cwd_count;
           int cwd_end;
           int cwd_start;
           int cwd_count;
           int cwd_end;
           int cwd_start;