]> sjero.net Git - dccp2tcp/commitdiff
Add warning about malformed ACK vectors
authorSamuel Jero <sj323707@ohio.edu>
Wed, 8 Jun 2011 03:07:43 +0000 (23:07 -0400)
committerSamuel Jero <sj323707@ohio.edu>
Wed, 8 Jun 2011 03:07:43 +0000 (23:07 -0400)
Linux Implementation will handle them incorrectly. It will count the packet as acked. ccid2.c line 657

dccp2tcp.c

index 71b7ece7b05b42ca6e617ec152b20f0cc968180a..1ab8ed198372618fba2074448b8d24870d84560b 100644 (file)
@@ -620,6 +620,10 @@ unsigned int interp_ack_vect(u_char* hdr)
                                if((*cur & 0xC0)==0x00){ //received packet
                                        bp+= (*cur & 0x3F)+1;
                                }
+
+                               if(((*cur& 0xF0)!= 0xC0) && ((*cur& 0xF0)!= 0x00) && ((*cur& 0xF0)!= 0x40)){
+                                       dbgprintf(1, "Warning: Invalid Ack Vector!! (Linux will handle poorly!)\n");
+                               }
                                tmp--;
                                cur++;
                        }