From: hniksic <devnull@localhost>
Date: Thu, 12 Apr 2001 12:58:02 +0000 (-0700)
Subject: [svn] Use octal constants.
X-Git-Tag: v1.13~2187
X-Git-Url: http://sjero.net/git/?p=wget;a=commitdiff_plain;h=b4b33b5afc0b2d819dda6296d11d3108081b97ee

[svn] Use octal constants.
Published in <sxsr8yy1dk6.fsf@florida.arsdigita.de>.
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 1e543cbb..a896f8b8 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2001-04-12  Hrvoje Niksic  <hniksic@arsdigita.com>
+
+	* ftp-ls.c (ftp_parse_unix_ls): Use octal constants for
+	permissions.  A compiler that doesn't accept octal constants is
+	seriously broken and shouldn't be used -- octal constants were
+	present in K&R C!
+
 2001-01-20  Karl Eichwalder  <ke@suse.de>
 
 	* Makefile.in: Provide and use DESTDIR according to the Coding
diff --git a/src/ftp-ls.c b/src/ftp-ls.c
index 338c1a4e..bd3309c6 100644
--- a/src/ftp-ls.c
+++ b/src/ftp-ls.c
@@ -155,15 +155,16 @@ ftp_parse_unix_ls (const char *file, int ignore_perms)
  	  switch (cur.type)
  	    {
  	    case FT_PLAINFILE:
- 	      cur.perms = 420;
+ 	      cur.perms = 0644;
  	      break;
  	    case FT_DIRECTORY:
- 	      cur.perms = 493;
+ 	      cur.perms = 0755;
  	      break;
  	    default:
- 	      cur.perms = 1023;
+ 	      /*cur.perms = 1023;*/	/* #### What is this?  --hniksic */
+	      cur.perms = 0644;
  	    }
- 	  DEBUGP (("implicite perms %0o; ", cur.perms));
+ 	  DEBUGP (("implicit perms %0o; ", cur.perms));
 	}
        else
          {
@@ -489,14 +490,14 @@ ftp_parse_winnt_ls (const char *file)
 	{
 	  cur.type  = FT_DIRECTORY;
 	  cur.size  = 0;
-	  cur.perms = 493; /* my gcc does not like 0755 ?? */
+	  cur.perms = 0755;
 	  DEBUGP(("Directory\n"));
 	}
       else
 	{
 	  cur.type  = FT_PLAINFILE;
 	  cur.size  = atoi(tok);
-	  cur.perms = 420; /* 0664 octal */
+	  cur.perms = 0644;
 	  DEBUGP(("File, size %ld bytes\n", cur.size));
 	}