From: Ángel González <keisial@gmail.com>
Date: Fri, 21 Jun 2013 22:06:31 +0000 (+0200)
Subject: Cleanup cmd_string_uppercase
X-Git-Tag: v1.15~47
X-Git-Url: http://sjero.net/git/?p=wget;a=commitdiff_plain;h=49f6d0ded862bc999fcfd46cdbf8b81442324388

Cleanup cmd_string_uppercase
---

diff --git a/src/ChangeLog b/src/ChangeLog
index 4299ac5c..bd191763 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2013-06-22  Ángel González <keisial@gmail.com>
+
+	* init.c (cmd_string_uppercase): Rewrite function.
+
 2013-06-19  Tim Ruehsen  <tim.ruehsen@gmx.de>
 
 	* connect.c (socket_ip_address): zero out ip address structure to
diff --git a/src/init.c b/src/init.c
index 54a29198..1c4432b5 100644
--- a/src/init.c
+++ b/src/init.c
@@ -965,15 +965,16 @@ cmd_string (const char *com, const char *val, void *place)
 static bool
 cmd_string_uppercase (const char *com, const char *val, void *place)
 {
-  char *q;
-  bool ret = cmd_string (com, val, place);
-  q = *((char **) place);
-  if (!ret || q == NULL)
-    return false;
+  char *q, **pstring;
+  pstring = (char **)place;
+  xfree_null (*pstring);
+
+  *pstring = xmalloc (strlen (val) + 1);
 
-  for ( ;*q; *q++)
-    *q = c_toupper (*q);
+  for (q = *pstring; *val; val++, q++)
+    *q = c_toupper (*val);
 
+  *q = '\0';
   return true;
 }