* fix a few little dissonances

diff --git a/src/ChangeLog b/src/ChangeLog
index 5639fd12e8bce83c07431cad9072c8510891c968..c91af04d569675cfa60e95d3a2b0b7ff987f3b28 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,11 @@
+2012-06-04  Tim Ruehsen  <tim.ruehsen@gmx.de>
+
+       * main.c (main): Check for filename != NULL.
+       * warc.c (warc_process_cdx_line): Fix memory leak.
+       * utils.c (match_posix_regex, compile_posix_regex): Remove dead
+   assignment.
+       * openssl.c (ssl_init): Fix old-style function definition.
+
 2012-06-02  Giuseppe Scrivano  <gscrivano@gnu.org>
 
        * connect.c: Include <sys/socket.h> and <sys/select.h>.

diff --git a/src/main.c b/src/main.c
index aac01ac875b85b6fea4f3bffb179ea78d48ccad1..dda91c72f9c6dc78edaef8e99db1c1a439c062a2 100644 (file)
--- a/src/main.c
+++ b/src/main.c
@@ -1566,7 +1566,7 @@ outputting to a regular file.\n"));
                           &dt, opt.recursive, iri, true);
           }
 
-          if (opt.delete_after && file_exists_p(filename))
+          if (opt.delete_after && filename != NULL && file_exists_p (filename))
             {
               DEBUGP (("Removing file due to --delete-after in main():\n"));
               logprintf (LOG_VERBOSE, _("Removing %s.\n"), filename);

diff --git a/src/openssl.c b/src/openssl.c
index f976455fa553d10feb009f280326550585edcbfd..3924e41ea19e9cf7af2c7b0e6296206753d1e789 100644 (file)
--- a/src/openssl.c
+++ b/src/openssl.c
@@ -159,7 +159,7 @@ key_type_to_ssl_type (enum keyfile_type type)
    Returns true on success, false otherwise.  */
 
 bool
-ssl_init ()
+ssl_init (void)
 {
   SSL_METHOD const *meth;
 

diff --git a/src/utils.c b/src/utils.c
index 55a8a8d286959dc50aa4d15d8b51a1840c7ca9e7..fb3ccd451671350360213f05a575963626f986c6 100644 (file)
--- a/src/utils.c
+++ b/src/utils.c
@@ -2355,7 +2355,7 @@ compile_posix_regex (const char *str)
     {
       int errbuf_size = regerror (errcode, (regex_t *) regex, NULL, 0);
       char *errbuf = xmalloc (errbuf_size);
-      errbuf_size = regerror (errcode, (regex_t *) regex, errbuf, errbuf_size);
+      regerror (errcode, (regex_t *) regex, errbuf, errbuf_size);
       fprintf (stderr, _("Invalid regular expression %s, %s\n"),
                quote (str), errbuf);
       xfree (errbuf);
@@ -2402,7 +2402,7 @@ match_posix_regex (const void *regex, const char *str)
     {
       int errbuf_size = regerror (rc, opt.acceptregex, NULL, 0);
       char *errbuf = xmalloc (errbuf_size);
-      errbuf_size = regerror (rc, opt.acceptregex, errbuf, errbuf_size);
+      regerror (rc, opt.acceptregex, errbuf, errbuf_size);
       logprintf (LOG_VERBOSE, _("Error while matching %s: %d\n"),
                  quote (str), rc);
       xfree (errbuf);

diff --git a/src/warc.c b/src/warc.c
index 92a49ef8a4ec98eef2bba955e8f4007212ca2462..69f80bebc62889edbf60c03bf60cddc2d6df50d5 100644 (file)
--- a/src/warc.c
+++ b/src/warc.c
@@ -913,6 +913,12 @@ warc_process_cdx_line (char *lineptr, int field_num_original_url,
           free (record_id);
         }
     }
+  else
+    {
+      xfree_null(checksum);
+      xfree_null(original_url);
+      xfree_null(record_id);
+    }
 }
 
 /* Loads the CDX file from opt.warc_cdx_dedup_filename and fills