X-Git-Url: http://sjero.net/git/?p=wget;a=blobdiff_plain;f=src%2Furl.c;h=eda1f54e41e4106b59432481c75f14b5fe6ff095;hp=87d6290ac1b032220345607de378f3e9ae2d6da9;hb=226785838ae29964a0cb063d959273ab8e133da7;hpb=242ddfc74e5381dc91e2abdb5b92e985ba16458a diff --git a/src/url.c b/src/url.c index 87d6290a..eda1f54e 100644 --- a/src/url.c +++ b/src/url.c @@ -169,7 +169,7 @@ static const unsigned char urlchr_table[256] = The transformation is done in place. If you need the original string intact, make a copy before calling this function. */ -static void +void url_unescape (char *s) { char *t = s; /* t - tortoise */ @@ -701,7 +701,10 @@ url_parse (const char *url, int *error, struct iri *iri, bool percent_encode) if (!iri->utf8_encode) new_url = NULL; else - iri->orig_url = xstrdup (url); + { + iri->orig_url = xstrdup (url); + percent_encode = true; + } } /* XXX XXX Could that change introduce (security) bugs ??? XXX XXX*/ @@ -1281,16 +1284,6 @@ append_null (struct growable *dest) *TAIL (dest) = 0; } -/* Shorten DEST to LENGTH. */ -static void -shorten_length (size_t length, struct growable *dest) -{ - if (length < dest->tail) - dest->tail = length; - - append_null (dest); -} - /* Append CH to DEST. */ static void append_char (char ch, struct growable *dest) @@ -1617,7 +1610,26 @@ url_file_name (const struct url *u, char *replaced_filename) append_char ('\0', &temp_fnres); /* Check that the length of the file name is acceptable. */ +#ifdef WINDOWS + if (MAX_PATH > (fnres.tail + CHOMP_BUFFER + 2)) + { + max_length = MAX_PATH - (fnres.tail + CHOMP_BUFFER + 2); + /* FIXME: In Windows a filename is usually limited to 255 characters. + To really be accurate you could call GetVolumeInformation() to get + lpMaximumComponentLength + */ + if (max_length > 255) + { + max_length = 255; + } + } + else + { + max_length = 0; + } +#else max_length = get_max_length (fnres.base, fnres.tail, _PC_NAME_MAX) - CHOMP_BUFFER; +#endif if (max_length > 0 && strlen (temp_fnres.base) > max_length) { logprintf (LOG_NOTQUIET, "The name is too long, %lu chars total.\n", @@ -1650,11 +1662,12 @@ url_file_name (const struct url *u, char *replaced_filename) 2) Retrieval with regetting. 3) Timestamping is used. 4) Hierarchy is built. + 5) Backups are specified. The exception is the case when file does exist and is a directory (see `mkalldirs' for explanation). */ - if ((opt.noclobber || opt.always_rest || opt.timestamping || opt.dirstruct) + if (ALLOW_CLOBBER && !(file_exists_p (fname) && !file_non_directory_p (fname))) { unique = fname;