X-Git-Url: http://sjero.net/git/?p=wget;a=blobdiff_plain;f=src%2Fretr.c;h=39627e4bbf5067e8ea563ac110c39c44e1cf087a;hp=8752dce71510d3ef3819bdbbb4ba7a0906aa1c4a;hb=d5e283b1a75c5f8249300b465b4e7b55130bec49;hpb=a9da78c6d8f9e2699107fcde81efeb607dde1cca diff --git a/src/retr.c b/src/retr.c index 8752dce7..39627e4b 100644 --- a/src/retr.c +++ b/src/retr.c @@ -143,8 +143,10 @@ limit_bandwidth (wgint bytes, struct ptimer *timer) static int write_data (FILE *out, const char *buf, int bufsize, wgint *skip, - wgint *written) + wgint *written, int flags) { + static int cr_pending = 0; /* Found CR in ASCII FTP data. */ + if (!out) return 1; if (*skip > bufsize) @@ -161,14 +163,89 @@ write_data (FILE *out, const char *buf, int bufsize, wgint *skip, return 1; } - fwrite (buf, 1, bufsize, out); - *written += bufsize; +/* Note: This code assumes that "\n" is the universal line ending + character, as on UNIX and VMS. If this is not true, then here's + where to change it. +*/ + +#if 1 +# define EOL_STRING "\n" +#else /* 1 */ +# define EOL_STRING "\r\n" +#endif /* 1 [else] */ +#define EOL_STRING_LEN (sizeof( EOL_STRING)- 1) + + if (flags & rb_ftp_ascii) + { + const char *bufend; + + /* ASCII transfer. Put out lines delimited by CRLF. */ + bufend = buf+ bufsize; + while (buf < bufend) + { + /* If CR, put out any pending CR, then set CR-pending flag. */ + if (*buf == '\r') + { + if (cr_pending) + { + fwrite ("\r", 1, 1, out); + *written += 1; + } + cr_pending = 1; + buf++; + continue; + } + + if (cr_pending) + { + if (*buf == '\n') + { + /* Found FTP EOL (CRLF). Put out local EOL. */ + fwrite (EOL_STRING, 1, EOL_STRING_LEN, out); + *written += EOL_STRING_LEN; + } + else + { + /* Normal character. Put out pending CR and it. */ + fwrite ("\r", 1, 1, out); + fwrite (buf, 1, 1, out); + *written += 2; + } + buf++; + cr_pending = 0; + } + else + { + /* Normal character. Put it out. */ + fwrite (buf, 1, 1, out); + *written += 1; + buf++; + } + } + } + else + { + /* Image transfer. Put out buffer. */ + fwrite (buf, 1, bufsize, out); + *written += bufsize; + } /* Immediately flush the downloaded data. This should not hinder performance: fast downloads will arrive in large 16K chunks (which stdio would write out immediately anyway), and slow downloads wouldn't be limited by disk speed. */ + + /* 2005-04-20 SMS. + Perhaps it shouldn't hinder performance, but it sure does, at least + on VMS (more than 2X). Rather than speculate on what it should or + shouldn't do, it might make more sense to test it. Even better, it + might be nice to explain what possible benefit it could offer, as + it appears to be a clear invitation to poor performance with no + actual justification. (Also, why 16K? Anyone test other values?) + */ +#ifndef __VMS fflush (out); +#endif /* ndef __VMS */ return !ferror (out); } @@ -299,7 +376,7 @@ fd_read_body (int fd, FILE *out, wgint toread, wgint startpos, if (ret > 0) { sum_read += ret; - if (!write_data (out, dlbuf, ret, &skip, &sum_written)) + if (!write_data (out, dlbuf, ret, &skip, &sum_written, flags)) { ret = -2; goto out; @@ -605,6 +682,7 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, uerr_t result; char *url; bool location_changed; + bool iri_fallbacked = 0; int dummy; char *mynewloc, *proxy; struct url *u = orig_parsed, *proxy_url; @@ -628,15 +706,11 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, if (file) *file = NULL; - second_try: - DEBUGP (("[IRI Retrieving %s with %s (UTF-8=%d)\n", quote_n (0, url), - iri->uri_encoding ? quote_n (1, iri->uri_encoding) : "None", - iri->utf8_encode)); - if (!refurl) refurl = opt.referer; redirected: + /* (also for IRI fallbacking) */ result = NOCONERROR; mynewloc = NULL; @@ -805,7 +879,9 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, if (u) { DEBUGP (("[IRI fallbacking to non-utf8 for %s\n", quote (url))); - goto second_try; + url = xstrdup (u->url); + iri_fallbacked = 1; + goto redirected; } else DEBUGP (("[Couldn't fallback to non-utf8 for %s\n", quote (url))); @@ -840,7 +916,7 @@ retrieve_url (struct url * orig_parsed, const char *origurl, char **file, url_free (u); } - if (redirection_count) + if (redirection_count || iri_fallbacked) { if (newloc) *newloc = url;